Skip to content

Add support for R-GCIP tenant configuration #14979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: [Auth] Regionalised Auth and BYO-CIAM feature implementation
merged 10 commits into from
Jun 26, 2025
Merged

Add support for R-GCIP tenant configuration #14979

merged 10 commits into from
Jun 26, 2025

Conversation

@srushtisv
Copy link
Contributor

Description

This PR introduces support for Regional GCIP (R-GCIP) within the Firebase Auth iOS SDK. Developers can now initialize an Auth instance tied to a specific tenant ID and location.

The key changes are:

  • New TenantConfig Struct: A Sendable struct TenantConfig has been added to hold the tenantId and location (defaulting to "prod-global").
  • New Auth Factory Method: A new static method Auth.auth(app: FirebaseApp, tenantConfig: TenantConfig) allows initialization with R-GCIP parameters.
  • Updated AuthRequestConfiguration: The internal AuthRequestConfiguration class now includes location and tenantId properties, populated during initialization if a TenantConfig is provided.

These changes enable applications to work with regionalized Firebase Authentication backends.

Changelog

  • [FirebaseAuth] - Added support for Regional GCIP (R-GCIP) by introducing TenantConfig and a new Auth initializer to specify tenant ID and location.

@srushtisv srushtisv self-assigned this Jun 13, 2025
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@srushtisv srushtisv requested a review from pashanka June 16, 2025 07:52
@srushtisv srushtisv marked this pull request as ready for review June 16, 2025 07:52
@srushtisv srushtisv requested a review from ncooke3 June 16, 2025 07:56
ncooke3
ncooke3 approved these changes Jun 18, 2025
View reviewed changes
ncooke3
ncooke3 reviewed Jun 18, 2025
View reviewed changes
pashanka
pashanka requested changes Jun 19, 2025
View reviewed changes
@srushtisv srushtisv requested review from ncooke3 and pashanka June 23, 2025 21:09
ncooke3
ncooke3 reviewed Jun 24, 2025
View reviewed changes
ncooke3
ncooke3 approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one code suggestion above.

pashanka
pashanka approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@pashanka pashanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from one comment.

@srushtisv srushtisv merged commit 3da5a6d into byociam-sv Jun 26, 2025
53 checks passed
@srushtisv srushtisv deleted the auth-rgcip branch June 26, 2025 20:34
@firebase firebase locked and limited conversation to collaborators Jul 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@pashanka pashanka pashanka approved these changes

Assignees

@srushtisv srushtisv

Labels

api: auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srushtisv @google-oss-bot @ncooke3 @pashanka